Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for log colorization test due to merge overlap with #25289 #25438

Merged
merged 1 commit into from
Jan 7, 2018

Conversation

c42f
Copy link
Member

@c42f c42f commented Jan 7, 2018

Emergency fix for CI due to merge overlap (CI race condition!) between #25370 and #25289

CC @KristofferC

@KristofferC
Copy link
Member

Lgtm, let's merge quickly when this passes.

@nalimilan
Copy link
Member

CircleCI failures look unrelated (timeout).

@andreasnoack
Copy link
Member

andreasnoack commented Jan 7, 2018

CircleCI failures look unrelated (timeout).

Looks like a connectivity issue when downloading PCRE

Connection timed out after 15930 milliseconds
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:01 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:02 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:03 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:04 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:05 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:06 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:07 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:08 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:09 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:10 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:11 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:12 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:13 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:14 --:--:--     0curl: (28) Connection timed out after 15000 milliseconds
/home/circleci/project/deps/pcre.mk:8: recipe for target '/home/circleci/project/deps/srccache/pcre2-10.30.tar.bz2' failed
make[1]: *** [/home/circleci/project/deps/srccache/pcre2-10.30.tar.bz2] Error 28
Makefile:83: recipe for target 'julia-deps' failed
make: *** [julia-deps] Error 2
Exited with code 2

@c42f
Copy link
Member Author

c42f commented Jan 7, 2018

FWIW, the full test suite passes locally. Ah, and I see FreeBSD has completed successfully.

By the way I think we could fix the above category of CI timeout pretty simply by caching tarballs of the thirdparty deps in an S3 bucket (bonus points for putting the bucket it in the same region as the CI system). I did this for a previous build system and it worked really nicely.

@StefanKarpinski
Copy link
Member

AppVeyor 32-bit failure is a timeout; Circle CI failures seem to be some kind of build problem.

@StefanKarpinski StefanKarpinski merged commit 7b4ebf4 into master Jan 7, 2018
@StefanKarpinski StefanKarpinski deleted the cjf/fix-log-color-test branch January 7, 2018 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants