Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typemap: fix bug with handling of Tuple{} #26675

Merged
merged 1 commit into from
Apr 3, 2018
Merged

typemap: fix bug with handling of Tuple{} #26675

merged 1 commit into from
Apr 3, 2018

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Apr 2, 2018

introduced by e0aee18

@Keno Keno requested a review from JeffBezanson April 2, 2018 03:48
@Keno
Copy link
Member

Keno commented Apr 2, 2018

Add a test?

@ararslan ararslan added types and dispatch Types, subtyping and method dispatch needs tests Unit tests are required for this change labels Apr 2, 2018
@vtjnash vtjnash merged commit 049b9bc into master Apr 3, 2018
@vtjnash vtjnash deleted the jn/26607 branch April 3, 2018 17:11
@JeffBezanson
Copy link
Member

Yes, I'm curious: how was this triggered?

@JeffBezanson
Copy link
Member

I see; 7934810 introduced the first use of Tuple{} as a typemap key.

@JeffBezanson
Copy link
Member

Test case from #26607 should be added.

@ararslan
Copy link
Member

ararslan commented Apr 3, 2018

Why was this merged without a test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffBezanson JeffBezanson Awaiting requested review from JeffBezanson

Assignees
No one assigned
Labels
needs tests Unit tests are required for this change types and dispatch Types, subtyping and method dispatch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vtjnash @Keno @JeffBezanson @ararslan