Ignore build_h.jl.phony
#27628
Merged
Ignore build_h.jl.phony
#27628
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `version_git.sh` to build `version_git.jl`, we encode whether the current buildtree is modified. Unfortunately, this often runs in parallel with the generation of `build_h.jl`, which means that more often than not, `build_h.jl.phony` is sitting around in the build tree, and since `git` hasn't been told to ignore that file, we get modified build trees a lot during `make -jN`. We don't see this in final builds however, because when we swing back around in `make binary-dist`, the Makefile regenerates `version_git.jl.phony`, checks it against `version_git.jl` and notices that `git` no longer things the build tree is dirty. (This being because `build_h.jl.phony` does not exist. Note that we never run `make binary-dist` in parallel). Thus, we always end up with a `version_git.jl` that identifies itself as coming from a pristine build, and the price we paid was just that we would always build the system image twice. Come, global warming, come.
|
Verification run going here: https://build.julialang.org/#/builders/43/builds/1450 . If all goes according to plan, it will only build the sysimg once (well, once for |
|
Looks like the system image built once in |
|
.....dropping the total build time from 48 minutes to 23 minutes. 🎉 |
ararslan
added
building
|
CI failures are unrelated: FreeBSD build froze, Travis Linux x64 is #27109, Circle x64 got OOM killed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
version_git.shto buildversion_git.jl, we encode whether the current buildtree is modified. Unfortunately, this often runs in parallel with the eneration ofbuild_h.jl, which means that more often than not,build_h.jl.phonyis sitting around in the build tree, and sincegithasn't been told to ignore that file, we get modified build trees a lot duringmake -jN.We don't see this in final builds however, because when we swing back around in
make binary-dist, the Makefile regeneratesversion_git.jl.phony, checks it againstversion_git.jland notices thatgitno longer things the build tree is dirty. (This being becausebuild_h.jl.phonydoes not exist. Note that we never runmake binary-distin parallel). Thus, we always end up with aversion_git.jlthat identifies itself as coming from a pristine build, and the price we paid was just that we would always build the system image twice.This closes #27548