Address some missed shred calls #27801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omus
added
libgit2
mbauman
approved these changes
Jun 26, 2018
|
Not sure whether it's related, but FreeBSD seems to be freezing on the LibGit2 tests. I'll see if I can reproduce locally. |
|
Worked okay locally. |
|
FreeBSD failure is unreproducible, macOS failure is the FileWatching thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered some missing shred calls when using Julia 0.7-beta. These were noticed by using pkg
upwith a repo requiring credentials and reaching the prompt abort condition.Introduced in #27565