Fix issue #28624 #28635
Merged
Fix issue #28624 #28635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
pushed a commit
that referenced
this pull request
Aug 19, 2018
KristofferC
pushed a commit
that referenced
this pull request
Aug 19, 2018
Merged
KristofferC
pushed a commit
that referenced
this pull request
Aug 19, 2018
KristofferC
pushed a commit
that referenced
this pull request
Sep 8, 2018
KristofferC
pushed a commit
that referenced
this pull request
Sep 8, 2018
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #28624
The issue is actually caused by a bug on fish (which is fixed on fish master but isn't released yet). The fix won't mess with other shell's behaviour... would you guys be willing to accept this PR for fish user's sake?? 😄
To be honest, I have no idea why this line of code is needed... I just changed it to work with fish.