fix #29145, error for new{} with incomplete type
#29154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
error handling
JeffBezanson
force-pushed
the
jb/fix29145
branch
from
1320db9 to
7062481
Compare
Merged
KristofferC
pushed a commit
that referenced
this pull request
Sep 17, 2018
(cherry picked from commit c3660f7)
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
(cherry picked from commit c3660f7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also updated the interpreter code for
newto match codegen exactly, to make sure error handling is the same.The error thrown here isn't perfect (this is not really a type error in the same sense), but I felt it was helpful to include the type in question, and that's tricky to do from runtime system code.
fix #29145