Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hof mktemp/dir: don't error if temp path is already gone #33091

Merged
merged 1 commit into from
Aug 28, 2019
Merged

hof mktemp/dir: don't error if temp path is already gone #33091

merged 1 commit into from
Aug 28, 2019

Conversation

StefanKarpinski
Copy link
Member

@StefanKarpinski StefanKarpinski commented Aug 27, 2019 •
edited
Loading

@staticfloat, I know you mentioned that you'd prefer if this worked without an error.

@StefanKarpinski StefanKarpinski added needs news A NEWS entry is required for this change needs tests Unit tests are required for this change labels Aug 27, 2019
ararslan
ararslan reviewed Aug 27, 2019
View reviewed changes
base/file.jl Show resolved Hide resolved
@StefanKarpinski StefanKarpinski force-pushed the sk/mktemp-no-error-if-gone branch from 33a7e34 to fcb98f6 Compare August 27, 2019 23:10
@StefanKarpinski StefanKarpinski merged commit 76ec9d6 into master Aug 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the sk/mktemp-no-error-if-gone branch August 28, 2019 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ararslan ararslan ararslan left review comments

@staticfloat staticfloat staticfloat approved these changes

Assignees
No one assigned
Labels
needs news A NEWS entry is required for this change needs tests Unit tests are required for this change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StefanKarpinski @staticfloat @ararslan