propagate errors from flush within close
#35326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
reviewed
Apr 1, 2020
src/support/ios.c
Outdated
| { | ||
| ios_flush(s); | ||
| int err = ios_flush(s); | ||
| if (s->fd != -1 && s->ownfd) | ||
| close(s->fd); |
There was a problem hiding this comment.
check the return value of close also. Some file systems don't sync the buffers to disk until the fd is closed even with a preceding flush.
JeffBezanson
force-pushed
the
jb/closeerror
branch
from
1dd5177 to
ce73730
Compare
ravibitsgoa
pushed a commit
to ravibitsgoa/julia
that referenced
this pull request
Apr 9, 2020
ztultrebor
pushed a commit
to ztultrebor/julia
that referenced
this pull request
Apr 17, 2020
staticfloat
pushed a commit
that referenced
this pull request
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #35303.