Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match all regex #3589

Merged
merged 8 commits into from
Jun 30, 2013
Merged

Match all regex #3589

merged 8 commits into from
Jun 30, 2013

Conversation

nutsiepully
Copy link
Contributor

matchall function to find all occurrences of a regex pattern in a string.

Follow up on the last pull request - #3525

These commits fix the issues that were raised there.

@nutsiepully
Copy link
Contributor Author

@JeffBezanson @StefanKarpinski - please review. sorry for the delay on this one. did not get time over the week. it incorporates the changes discussed.

@StefanKarpinski
Copy link
Member

Great. At a casual glance, this is looking quite good. My only immediate objection is to the is_utf field – why do we need that? It isn't used anywhere that I can tell. It should also be called isutf8 since there are two other official UTF encodings: UTF-16 and UTF-32.

@nutsiepully
Copy link
Contributor Author

@StefanKarpinski - you're right - thanks for catching it. the is_utf field was relevant earlier when i was skipping characters myself. It's useless now. Fixed now.

@StefanKarpinski
Copy link
Member

Looks good.

@StefanKarpinski StefanKarpinski merged commit 1f62abc into JuliaLang:master Jun 30, 2013
@JeffBezanson
Copy link
Member

Thanks for this.

What is the config function for? It does not seem to be used.

@StefanKarpinski
Copy link
Member

It lets you query features the PCRE library was configured with. Seems harmless to include it in the low-level PCRE interface.

@nutsiepully nutsiepully deleted the match_all_regex branch July 1, 2013 05:33
KristofferC pushed a commit that referenced this pull request Sep 5, 2023
@DilumAluthgeBot @DilumAluthge
🤖 [master] Bump the Pkg stdlib from 047734e4c to f570abd39 (#51186)
fbf73f4 
Stdlib: Pkg
URL: https://github.com/JuliaLang/Pkg.jl.git
Stdlib branch: master
Julia branch: master
Old commit: 047734e4c
New commit: f570abd39
Julia version: 1.11.0-DEV
Pkg version: 1.11.0
Bump invoked by: @KristofferC
Powered by:
[BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl)

Diff:
JuliaLang/Pkg.jl@047734e...f570abd

```
$ git log --oneline 047734e4c..f570abd39
f570abd39 tweak how Pkg is loaded for precompiling when testing (#3606)
d3bd38b90 sort compat entries in `pkg> compat` (#3605)
5e07cfed0 Ensure that `string(::VersionSpec)` is compatible with `semver_spec()` (#3580)
6bed7c41a Clarify handling of LOAD_PATH in docstring and REPL help (#3589)
5261b3be7 tweak test dep docs (#3574)
72b430d50 status: expand 2 symbol upgrade note to highlight *may* be upgradable (#3576)
b32db473d precompile: show ext parent in output report (#3603)
```

Co-authored-by: Dilum Aluthge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nutsiepully @StefanKarpinski @JeffBezanson