more accurate and type-stable sinc/cosc #37273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
added
maths
JeffBezanson
approved these changes
Aug 29, 2020
|
MacOS test failure seems unrelated. |
|
@JeffBezanson, as I mentioned in the issue, I'm curious where you found this definition of the |
|
cosc definitely seems like one that should have moved out of base for 1.0 (maybe sinc too honestly). |
|
I added it to ChainRules.jl to differentiate |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37227.
(Replaces original algorithm from 2010! 1917197)
Backport?