Fix some string-related invalidation risks #37799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing some other tests on #37754, I got the impression that the number of at-risk MethodInstances had risen (#37741 (comment)). I'm still not sure it was causal, although precompiling Test methods makes sense as a potential source of newly-visible vulnerabilities. Whatever the origin, this PR reduces risk by helping inference mostly in path-related code (Pkg, BinaryPlatforms, and others). Together with JuliaLang/Pkg.jl#2049, this drops our mean number of backedges for at-risk signatures (xref #37193) from the mid-30s to around 20, quite a significant drop for such a small set of changes.