Fix some inference problems in logging #38292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aside from the preferences system (xref #38285) and TOML parsing, these appear to trigger the only remaining sources of vulnerability to invalidation of `Base.require` among Julia's *exported* names, which are the main names we can expect to be specialized by packages.
|
Since tests pass, let's give it a whirl; we can always back that part out if it's trouble. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aside from the preferences system (xref #38285) and TOML parsing,
these trigger what appear to be the only remaining sources of vulnerability to
invalidation of
Base.requireamong Julia's exported names,which are the main names we can expect to be specialized by packages.
My main uncertainty is whether adding
::LogLevelis OK, CC @c42f.EDIT: in case it's not clear,
Base.requiredeserves special attention: if your goal is to slow down package loading, you could hardly do better than invalidateBase.require. Bonus points for invalidating it with multiple package dependencies, since it would need recompilation each time it gets invalidated before the next package in the sequence can load.