-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update manual: Vararg{T,N} is not a type anymore #39239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you pointed out that the same text is duplicated in the Vararg docstring in basedocs.jl and should be fixed there also.
1.6 does not include the change that made Vargarg not a type. |
Should I recently addressed this issue here: |
That's generally just supposed to be spelled |
Would the intended way to define a function that accepts |
That is my preference, but opinions differ. More generally, maybe we should just have an expanded collection of reflection methods in base to avoid most uses for this. It's a bit unfortunate how widespread introspection of Vararg is across the package ecosystem. |
See JuliaLang/julia#39239 (comment) `Core.TypeofVararg` introduced in JuliaLang/julia#3813 `VERSION >= v"1.7.0-DEV.77"`
Actually I wasn't aware of the docstring -- I was talking about the text a few lines above where I edited it :-). But sure, I can align it with the docstring, too. |
I committed your suggestion, but I see the docstring indeed also needs tweaking, will try to take care of it. |
3f744fb
to
d1698ae
Compare
Updated. I've also contemplated extending the example(s), but it either gets a bit long or a bit complicated...
|
I used the term "special value" as that is used a few lines above.
Perhaps this could be backported to 1.6, to avoid confusion there, too?