Optimisation of getproperty for UmfpackLU object #40663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkarrasch
added
linear algebra
|
This needs some tests, but otherwise looks great. |
cfauchereau
force-pushed
the
umfpack_getproperty_optim
branch
from
f635263 to
0fbbb20
Compare
|
I added tests to assess that accessing elements individually works as intended. I am not sure what else there is to test, let me know if you see something that is not covered. |
dkarrasch
reviewed
Apr 30, 2021
dkarrasch
reviewed
Apr 30, 2021
…evant information)
cfauchereau
force-pushed
the
umfpack_getproperty_optim
branch
from
0fbbb20 to
0fb5d6f
Compare
dkarrasch
approved these changes
May 1, 2021
|
I think it's ready. |
That's what I feel too. |
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
…evant information) (JuliaLang#40663)
ElOceanografo
added a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
using new efficient method from JuliaLang#40663
jarlebring
pushed a commit
to jarlebring/julia
that referenced
this pull request
May 4, 2021
…evant information) (JuliaLang#40663)
jarlebring
pushed a commit
to jarlebring/julia
that referenced
this pull request
May 6, 2021
…evant information) (JuliaLang#40663)
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
…evant information) (JuliaLang#40663)
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
…evant information) (JuliaLang#40663)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix JuliaLang/LinearAlgebra.jl#827
When calling
getpropertyon anUmfpackLUobject only the requested information is copied in the call toumfpack_*_get_numeric.It is faster and more memory efficient.