Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland "change setup_stdio default method to support any IO" #40973

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented May 27, 2021

Need to figure out why this caused the buildbots to break from #40780

@vtjnash vtjnash force-pushed the revert-40971-revert-40780-jn/39984 branch from 7135813 to 17fd292 Compare July 28, 2021 18:14
@vtjnash vtjnash force-pushed the revert-40971-revert-40780-jn/39984 branch 2 times, most recently from dade4e8 to 80b0d62 Compare August 20, 2021 15:42
@vtjnash vtjnash marked this pull request as ready for review August 20, 2021 16:54
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Aug 23, 2021
@vtjnash vtjnash requested a review from Keno August 23, 2021 20:34
…#40971)

This reverts commit 7edd190, and fixes
a method type signature error, which caused TTY to get shutdown.
@vtjnash vtjnash force-pushed the revert-40971-revert-40780-jn/39984 branch from 80b0d62 to b2ecc46 Compare September 1, 2021 17:21
@vtjnash vtjnash merged commit 3aada59 into master Sep 1, 2021
@vtjnash vtjnash deleted the revert-40971-revert-40780-jn/39984 branch September 1, 2021 19:46
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Sep 6, 2021
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
…g#40780)" (JuliaLang#40971) (JuliaLang#40973)

This reverts commit 7edd190, and fixes
a method type signature error, which caused TTY to get shutdown.
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
…g#40780)" (JuliaLang#40971) (JuliaLang#40973)

This reverts commit 7edd190, and fixes
a method type signature error, which caused TTY to get shutdown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants