Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LLVM] upgrade LLVM to 12.0.1 #41629

Merged
merged 3 commits into from
Jul 20, 2021
Merged

[LLVM] upgrade LLVM to 12.0.1 #41629

merged 3 commits into from
Jul 20, 2021

Conversation

vchuravy
Copy link
Member

No description provided.

@vchuravy vchuravy added this to the 1.7 milestone Jul 18, 2021
@vchuravy vchuravy added backport 1.7 external dependencies Involves LLVM, OpenBLAS, or other linked libraries labels Jul 18, 2021
@vchuravy
Copy link
Member Author

@staticfloat @vtjnash in order to not have broken CMakeFiles for dependent projects Clang_jll now has the clang binary in bin/clang instead of tools/clang. We could fix that post install, but I would rather keep things consistent.

@vchuravy vchuravy force-pushed the vc/llvm_12.0.1 branch 3 times, most recently from ee6a520 to ab531a1 Compare July 18, 2021 13:47
@vchuravy vchuravy requested a review from staticfloat July 18, 2021 15:44
@KristofferC KristofferC mentioned this pull request Jul 19, 2021
Merged
82 tasks
staticfloat
staticfloat approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@staticfloat staticfloat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, glad that we no longer have the tools/bin confusion, and we can reliably use bin now.

@vchuravy vchuravy merged commit 6279f3b into master Jul 20, 2021
@vchuravy vchuravy deleted the vc/llvm_12.0.1 branch July 20, 2021 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staticfloat staticfloat staticfloat approved these changes

Assignees
No one assigned
Labels
external dependencies Involves LLVM, OpenBLAS, or other linked libraries
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
3 participants
@vchuravy @staticfloat @KristofferC