Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixup! Merge pull request #38405 from JuliaLang/vc/distributed_ts #41641

Merged
merged 1 commit into from
Jul 19, 2021
Merged

fixup! Merge pull request #38405 from JuliaLang/vc/distributed_ts #41641

merged 1 commit into from
Jul 19, 2021

Conversation

vchuravy
Copy link
Member

No description provided.

@vchuravy vchuravy added backport 1.7 embarrassing-bugfix Whoops! multithreading Base.Threads and related functionality labels Jul 19, 2021
@vchuravy vchuravy requested a review from JeffBezanson July 19, 2021 15:44
Sacha0
Sacha0 approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Valentin! :)

@JeffBezanson JeffBezanson merged commit 5af1cf0 into master Jul 19, 2021
@JeffBezanson JeffBezanson deleted the vc/fixup branch July 19, 2021 20:42
@KristofferC KristofferC mentioned this pull request Jul 26, 2021
Merged
82 tasks
KristofferC pushed a commit that referenced this pull request Jul 26, 2021
@vchuravy @KristofferC
fixup to pull request #38405 (#41641)
f3da8d9 
(cherry picked from commit 5af1cf0)
vtjnash added a commit that referenced this pull request Jul 28, 2021
@vtjnash
Revert "Merge pull request #38405 from JuliaLang/vc/distributed_ts"
1fa2223 
Revert "fixup to pull request #38405 (#41641)"

Seems to be causing hanging in CI testing?

This reverts commit 5af1cf0.
This reverts commit 5a16805, reversing
changes made to 02807b2.
@vtjnash vtjnash mentioned this pull request Jul 28, 2021
Merged
vtjnash added a commit that referenced this pull request Jul 29, 2021
@vtjnash
Revert "Merge pull request #38405 from JuliaLang/vc/distributed_ts" (#…
66f9b55 
…41722)

Also reverts "fixup to pull request #38405 (#41641)"

Seems to be causing hanging in CI testing.

This reverts commit 5af1cf0 and this
reverts commit 5a16805, reversing
changes made to 02807b2.
KristofferC pushed a commit that referenced this pull request Aug 2, 2021
@vtjnash @KristofferC
Revert "Merge pull request #38405 from JuliaLang/vc/distributed_ts" (#…
84e6bb9 
…41722)

Also reverts "fixup to pull request #38405 (#41641)"

Seems to be causing hanging in CI testing.

This reverts commit 5af1cf0 and this
reverts commit 5a16805, reversing
changes made to 02807b2.

(cherry picked from commit 66f9b55)
vchuravy added a commit to JuliaLang/Distributed.jl that referenced this pull request Oct 6, 2023
@vchuravy @KristofferC
fixup to pull request JuliaLang/julia#38405 (JuliaLang/julia#41641)
b14100c 
(cherry picked from commit 740a33a)
vchuravy pushed a commit to JuliaLang/Distributed.jl that referenced this pull request Oct 6, 2023
@vtjnash @KristofferC
Revert "Merge pull request JuliaLang/julia#38405 from JuliaLang/vc/di…
e36d6e3 
…stributed_ts" (JuliaLang/julia#41722)

Also reverts "fixup to pull request JuliaLang/julia#38405 (JuliaLang/julia#41641)"

Seems to be causing hanging in CI testing.

This reverts commit 740a33a and this
reverts commit 5a1680533b461471f537f5f5d4ee3c2866b21e1f, reversing
changes made to 02807b279a5e6d5acaeb7095e4c0527e2a5c190e.

(cherry picked from commit bbc9429)
Keno pushed a commit that referenced this pull request Jun 5, 2024
@vchuravy
fixup to pull request #38405 (#41641)
740a33a
Keno pushed a commit that referenced this pull request Jun 5, 2024
@vtjnash
Revert "Merge pull request #38405 from JuliaLang/vc/distributed_ts" (#…
bbc9429 
…41722)

Also reverts "fixup to pull request #38405 (#41641)"

Seems to be causing hanging in CI testing.

This reverts commit 740a33a and this
reverts commit 5a16805, reversing
changes made to 02807b2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sacha0 Sacha0 Sacha0 approved these changes

@JeffBezanson JeffBezanson Awaiting requested review from JeffBezanson

Assignees
No one assigned
Labels
embarrassing-bugfix Whoops! multithreading Base.Threads and related functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vchuravy @Sacha0 @JeffBezanson @KristofferC