Add namedstyle argument to printstyled #41910
Conversation
| @@ -43,6 +43,8 @@ const disable_text_style = Dict{Symbol,String}( | |||
| :nothing => "", | |||
| ) | |||
|
|
|||
| const named_styles = Dict{String, NamedTuple{(:color, :properties), Tuple{Union{Symbol,Int}, Dict{Symbol, Bool}}}}() | |||
There was a problem hiding this comment.
Unlike the implementation in #41435 (comment), I've made the values a namedtuple here. This should provide some "future-proofing", if with_output_color gains an argument for the background color, see #41435 (comment)
|
This will need to add tests, and possible documentation before it would be ready for merging (and, in fact, it might be good to take a serious stab at the second PR in my outline before considering it for a merge). I just wanted to get a concrete proposal out, so that any discussion of implementation details can be done here instead of cluttering up the discussion for #41435. I'm not strongly invested in this solution, so if @StefanKarpinski thinks this isn't a worthwhile direction to pursue, I don't mind closing this PR. |
goerz
force-pushed
the
41435-namedstyles
branch
5 times, most recently
from
66118d7 to
e4533a1
Compare
This adds an (empty) global dict `named_styles` and an argument `namedstyle` for the `printstyled` method that takes default color and text properties from the `named_styles` dict.
goerz
force-pushed
the
41435-namedstyles
branch
from
e4533a1 to
eb32c1c
Compare
Adds an (empty) global dict
named_styles, and an argumentnamedstylefor theprintstyledmethod that takes default color and text properties from thenamed_stylesdict.This is the first step in a proposal for addressing #41435
See #41435 (comment) for the underlying motivation