Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile: Use two null block terminators #42106

Merged
merged 2 commits into from
Sep 4, 2021

Conversation

IanButterworth
Copy link
Member

Fixes current failures on 32-bit linux.

It seems CI was lucky in passing in #41742
There was a couple more places that block end detection needed the new heuristic to ignore the rogue 0's on 32-bit linux

I also made block end detection a function given it's used in various places now

@vtjnash
Copy link
Member

vtjnash commented Sep 3, 2021

Would it help to separate them by 2 NULLs? Unlike a single NULL (which can appear in a trace), a double-NULL should not be possible. Or use -1 to separate them (which we already use to mark the start of special frames)?

@IanButterworth
Copy link
Member Author

IanButterworth commented Sep 3, 2021

Impossible is definitely nicer, but that would likely break downstream consumers like vscode's profile viewer etc.
Currently it's highly unlikely that this approach wouldn't work, I believe. Perhaps that's ok?

@vtjnash
Copy link
Member

vtjnash commented Sep 3, 2021

We used to delineate with double-NULL until quite recently, in many cases, due to a bug, so that would be no worse than before 😂.

I was also assuming this function may still normalize to alter the marker data, as the PR does now, IIUC.

@IanButterworth
Copy link
Member Author

Sounds good. Just implemented that

@DilumAluthge DilumAluthge requested review from vtjnash and NHDaly and removed request for vtjnash September 4, 2021 00:06
@IanButterworth IanButterworth changed the title Profile: More guards against rogue 0's on 32-bit linux Profile: Use two null block terminators Sep 4, 2021
@IanButterworth
Copy link
Member Author

I believe this is as discussed, so I'll merge to get CI back on track

@IanButterworth IanButterworth merged commit 8812c5c into JuliaLang:master Sep 4, 2021
@IanButterworth IanButterworth deleted the ib/fix_profile branch September 4, 2021 16:48
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants