-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profile: Use two null block terminators #42106
Profile: Use two null block terminators #42106
Conversation
071fb83
to
2fccb63
Compare
Would it help to separate them by 2 NULLs? Unlike a single NULL (which can appear in a trace), a double-NULL should not be possible. Or use |
Impossible is definitely nicer, but that would likely break downstream consumers like vscode's profile viewer etc. |
We used to delineate with double-NULL until quite recently, in many cases, due to a bug, so that would be no worse than before 😂. I was also assuming this function may still normalize to alter the marker data, as the PR does now, IIUC. |
Sounds good. Just implemented that |
f9e7abf
to
8bf9725
Compare
8bf9725
to
fd2713b
Compare
I believe this is as discussed, so I'll merge to get CI back on track |
Fixes current failures on 32-bit linux.
It seems CI was lucky in passing in #41742
There was a couple more places that block end detection needed the new heuristic to ignore the rogue 0's on 32-bit linux
I also made block end detection a function given it's used in various places now