-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a @compile
directive to disable interpreter
#42128
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently use a `while false; end` hack to disable to interpreter, and this is getting more widely used outside of base. Unfortunately, improvements to the interpreter that would allow us to interpret loops would defeat the intention. This allows developers to annotate blocks with `@compile` to specify that they want to force the compiler to run on this block.
aviatesk
approved these changes
Sep 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This is great to have.
timholy
added a commit
that referenced
this pull request
Sep 28, 2021
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
We currently use a `while false; end` hack to disable to interpreter, and this is getting more widely used outside of base. Unfortunately, improvements to the interpreter that would allow us to interpret loops would defeat the intention. This allows developers to annotate blocks with `@compile` to specify that they want to force the compiler to run on this block.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
There was an unintended collision in meaning between JuliaLang#42128 and JuliaLang#37041. Since both use the `Expr(:meta)` mechanism, it doesn't really seem feasible to have them both use the same name. Consequently, it's better to rename the newer meaning. Fixes JuliaLang#42373
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
We currently use a `while false; end` hack to disable to interpreter, and this is getting more widely used outside of base. Unfortunately, improvements to the interpreter that would allow us to interpret loops would defeat the intention. This allows developers to annotate blocks with `@compile` to specify that they want to force the compiler to run on this block.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
There was an unintended collision in meaning between JuliaLang#42128 and JuliaLang#37041. Since both use the `Expr(:meta)` mechanism, it doesn't really seem feasible to have them both use the same name. Consequently, it's better to rename the newer meaning. Fixes JuliaLang#42373
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use a
while false; end
hack to disable to interpreter,and this is getting more widely used outside of base. Unfortunately,
improvements to the interpreter that would allow us to interpret loops
would defeat the intention. This allows developers to annotate blocks
with
@compile
to specify that they want to force the compiler to runon this block.