avoid Any32 type in filter for tuples
#42263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
Sep 15, 2021
timholy
approved these changes
Sep 15, 2021
ararslan
approved these changes
Sep 15, 2021
|
I think this should have had at least several more approvals before merging, 4 is not enough |
84 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is sufficient to fix the case in that issue, but we should probably stop using these types. After intersection, they tend to blow up into more complex long tuple types (tuples of many unions) that are intractable for subtyping. With some quick experiments, so far it looks to me like we can replace these with length checks now with no regressions.
fixes #42236