specialize hastypemax on Bool
#42300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `Bool` is not included in `Base.BitIntegerType`, `hastypemax(Bool)` falls back to the slow generic version. This reduces the performance of `digits!` with Boolean target vector (for `base=2`) significantly. Specializing `hastypemax` on `Bool` fixes this performance bug. In one of my applications, where `digits!` should only take a small fraction of the total runtime, fixing this improves the performance by more than 10%.
|
I don't see why this PR might cause |
ranocha
added a commit
to ranocha/BSeries.jl
that referenced
this pull request
Sep 18, 2021
|
freebsd tests are failing currently. not your fault |
oscardssmith
approved these changes
Sep 18, 2021
|
Thanks for the fast review! |
|
It would be great if this could be considered to be a performance bug and backported to v1.7.0 before it is released officially. |
|
is this a regression? if not, it's not backport worthy. |
KristofferC
pushed a commit
that referenced
this pull request
Sep 23, 2021
Since `Bool` is not included in `Base.BitIntegerType`, `hastypemax(Bool)` falls back to the slow generic version. This reduces the performance of `digits!` with Boolean target vector (for `base=2`) significantly. Specializing `hastypemax` on `Bool` fixes this performance bug. (cherry picked from commit e50603f)
84 tasks
KristofferC
pushed a commit
that referenced
this pull request
Sep 28, 2021
Since `Bool` is not included in `Base.BitIntegerType`, `hastypemax(Bool)` falls back to the slow generic version. This reduces the performance of `digits!` with Boolean target vector (for `base=2`) significantly. Specializing `hastypemax` on `Bool` fixes this performance bug.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
Since `Bool` is not included in `Base.BitIntegerType`, `hastypemax(Bool)` falls back to the slow generic version. This reduces the performance of `digits!` with Boolean target vector (for `base=2`) significantly. Specializing `hastypemax` on `Bool` fixes this performance bug.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Since `Bool` is not included in `Base.BitIntegerType`, `hastypemax(Bool)` falls back to the slow generic version. This reduces the performance of `digits!` with Boolean target vector (for `base=2`) significantly. Specializing `hastypemax` on `Bool` fixes this performance bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
Boolis not included inBase.BitIntegerType,hastypemax(Bool)falls back to the slow generic version. This reduces the performance ofdigits!with Boolean target vector (forbase=2) significantly. SpecializinghastypemaxonBoolfixes this performance bug.In one of my applications, where
digits!should only take a small fraction of the total runtime, fixing this improves the performance by more than 10%.