Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for JuliaLang/llvm-project #42436

Merged
merged 1 commit into from
Oct 5, 2021
Merged

add support for JuliaLang/llvm-project #42436

merged 1 commit into from
Oct 5, 2021

Conversation

vchuravy
Copy link
Member

@vchuravy vchuravy added the upstream The issue is with an upstream dependency, e.g. LLVM label Sep 30, 2021
@vchuravy vchuravy requested a review from vtjnash September 30, 2021 16:43
@vchuravy vchuravy marked this pull request as ready for review October 2, 2021 16:29
@vchuravy
Copy link
Member Author

vchuravy commented Oct 2, 2021 •
edited
Loading

@vtjnash I moved to git-external as you mentioned.

  • Optional: Support building against RV again
  • BUILD_CUSTOM_LIBCXX

vtjnash
vtjnash reviewed Oct 2, 2021
View reviewed changes
deps/llvm.mk Outdated Show resolved Hide resolved
vtjnash
vtjnash reviewed Oct 2, 2021
View reviewed changes
deps/llvm.mk Outdated Show resolved Hide resolved
vtjnash
vtjnash reviewed Oct 2, 2021
View reviewed changes
deps/llvm.mk Outdated Show resolved Hide resolved
vtjnash
vtjnash reviewed Oct 2, 2021
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great to be deleting so many lines, remove the patches themselves too?

@vchuravy vchuravy requested review from vtjnash and Keno October 2, 2021 19:08
vtjnash
vtjnash reviewed Oct 4, 2021
View reviewed changes
deps/llvm.version Outdated Show resolved Hide resolved
@vchuravy vchuravy added the merge me PR is reviewed. Merge when all tests are passing label Oct 4, 2021
@vchuravy vchuravy merged commit c7fc80c into master Oct 5, 2021
@vchuravy vchuravy deleted the vc/jl_llvm branch October 5, 2021 13:58
@KristofferC KristofferC mentioned this pull request Oct 5, 2021
Merged
84 tasks
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Oct 7, 2021
@fxcoudert fxcoudert mentioned this pull request Mar 7, 2022
Closed
@fxcoudert
Copy link
Contributor

fxcoudert commented Mar 7, 2022 •
edited
Loading

This causes a build failure on master: #44499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

@Keno Keno Awaiting requested review from Keno

Assignees
No one assigned
Labels
upstream The issue is with an upstream dependency, e.g. LLVM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vchuravy @fxcoudert @vtjnash @KristofferC @DilumAluthge