Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compat note for printstyled #42547

Merged
merged 5 commits into from
Oct 8, 2021
Merged

Conversation

mcabbott
Copy link
Contributor

@mcabbott mcabbott commented Oct 8, 2021

The keywords underline=true, blink=true etc. added to printstyled in #40288 don't exist before Julia 1.7, so this adds a note.

It also tries to tidy up the docstring, as too many sentences like "If the keyword underline is given as true, the result will be printed underlined" one after another start to get redundant. And adds a few "see also" links.

Should there also be a note in https://github.com/JuliaLang/julia/blob/master/HISTORY.md#standard-library-changes ?

@fredrikekre fredrikekre added backport 1.7 display and printing Aesthetics and correctness of printed representations of objects. docs This change adds or pertains to documentation labels Oct 8, 2021
@fredrikekre fredrikekre merged commit f2080d5 into JuliaLang:master Oct 8, 2021
@mcabbott mcabbott deleted the printstyled_doc branch October 8, 2021 12:45
KristofferC pushed a commit that referenced this pull request Oct 19, 2021
(cherry picked from commit f2080d5)
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
display and printing Aesthetics and correctness of printed representations of objects. docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants