Fix #42670 - error in sparsevec outer product with stored zeros #42671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SparseMatrixCSC constructor checks that the passed in buffers have length matching the expected number of non-zeros, but the _outer constructor allocated buffers of the number of structural non-zeros, not actual non-zeros. Fix this by shrinking the buffers once the outer product is fully computed.
vtjnash
approved these changes
Oct 16, 2021
dkarrasch
reviewed
Oct 16, 2021
| C = sparsevec([0 0 1 1 0 0])' | ||
| A[2] = 1 | ||
| A[2] = 0 | ||
| @test A * C == B * C == spzeros(Int, 4, 6) |
There was a problem hiding this comment.
The test seems to be insufficiently specific as it passes even on v1.6. Perhaps we should include a test like this?
Suggested change
| @test A * C == B * C == spzeros(Int, 4, 6) | |
| @test A * C == B * C == spzeros(Int, 4, 6) | |
| @test length(nonzeros(A * C)) == length(nonzeros(B * C)) == 0 |
There was a problem hiding this comment.
That test doesn't test what I care about. I'm fine if the outer product doesn't drop non-structural zeros. If this test passes on 1.6, then this is just a regression, since it doesn't pass (as in throws an error) on master with the error message referenced in the issue.
There was a problem hiding this comment.
True, your test fails since v1.7. Shall we backport this to v1.7 then?
KristofferC
pushed a commit
that referenced
this pull request
Oct 18, 2021
The SparseMatrixCSC constructor checks that the passed in buffers have length matching the expected number of non-zeros, but the _outer constructor allocated buffers of the number of structural non-zeros, not actual non-zeros. Fix this by shrinking the buffers once the outer product is fully computed. (cherry picked from commit d885fc2)
84 tasks
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
…ros (JuliaLang#42671) The SparseMatrixCSC constructor checks that the passed in buffers have length matching the expected number of non-zeros, but the _outer constructor allocated buffers of the number of structural non-zeros, not actual non-zeros. Fix this by shrinking the buffers once the outer product is fully computed.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…ros (JuliaLang#42671) The SparseMatrixCSC constructor checks that the passed in buffers have length matching the expected number of non-zeros, but the _outer constructor allocated buffers of the number of structural non-zeros, not actual non-zeros. Fix this by shrinking the buffers once the outer product is fully computed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SparseMatrixCSC constructor checks that the passed in buffers
have length matching the expected number of non-zeros, but the
_outer constructor allocated buffers of the number of structural
non-zeros, not actual non-zeros. Fix this by shrinking the buffers
once the outer product is fully computed.
Fixes #42670.