-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docs for Experimental.@force_compile
#42760
Conversation
The doctest failure is surprising; does Documenter strip Since the same test is in |
When the doctest is running the code, there is extra stuff in the stack, so "interpreter" is probably sneaking in there. |
Also adds a direct test
3dd29b5
to
5ff4660
Compare
I just stripped the |
I think this caused a failure on MacOS here? |
This reverts commit 030a0f9.
Revert PR: #42784 |
For reference, the tests pass locally on my mac
|
This reverts commit 030a0f9.
Thanks for checking @IanButterworth; since I don't have a mac, that will save me some head-scratching. I would be tempted to just skip that test on a mac, but I think it will pay to be more careful than that. I'll submit a sequence of debugging commits as a draft to see if I can understand the failure. |
Also adds a direct test
…JuliaLang#42784) This reverts commit 030a0f9.
* Revert "Revert "Fix docs for `Experimental.@force_compile` (JuliaLang#42760)" (JuliaLang#42784)" This reverts commit dad4071. * Truncate test harness from stacktrace
Also adds a direct test
…JuliaLang#42784) This reverts commit 030a0f9.
* Revert "Revert "Fix docs for `Experimental.@force_compile` (JuliaLang#42760)" (JuliaLang#42784)" This reverts commit dad4071. * Truncate test harness from stacktrace
Also adds a direct test (we didn't used to have one and I hadn't really yet worked out how to do this). Responding to #42379 (comment)