-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow system versions of libwhich and libblastrampoline #43000
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
added
the
building
Build system, or building Julia or its dependencies
label
Nov 8, 2021
vtjnash
approved these changes
Nov 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to clarify, it looks like these are included in make -C deps get
(e.g. via make full-source-dist
) which should also stop them from being downloaded if USE_BINARYBUILDER is 0, right?
vchuravy
approved these changes
Nov 8, 2021
staticfloat
approved these changes
Nov 8, 2021
yuyichao
reviewed
Nov 9, 2021
yuyichao
added a commit
to archlinuxcn/repo
that referenced
this pull request
Nov 9, 2021
66 tasks
KristofferC
pushed a commit
that referenced
this pull request
Nov 10, 2021
(cherry picked from commit ee4bcab)
daviehh
pushed a commit
to daviehh/julia
that referenced
this pull request
Nov 16, 2021
) (cherry picked from commit ee4bcab)
haampie
added a commit
to haampie/julia
that referenced
this pull request
Nov 24, 2021
haampie
added a commit
to haampie/julia
that referenced
this pull request
Dec 6, 2021
haampie
added a commit
to haampie/julia
that referenced
this pull request
Dec 6, 2021
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Julia can't build on air-gapped systems because
libblastrampoline
andlibwhich
sources are always downloaded.This PR adds the missing
USE_SYSTEM_{LIBWHICH,LIBBLASTRAMPOLINE}
to fix that.