test/errorshow: Disable infinite recursion tests on aarch64-darwin #43613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We just don't get more than a couple frames back from libunwind on stack overflow when running on aarch64-darwin, so restrict the test to x64_64 also on macOS. This test also fails using the official 1.7.0 release binary.
31 tasks
|
Ideally, we'd figure out why the unwinder is broken, but since it appears to not work on non-x86_64 archs on Linux either, I guess we'll give it a pass for now. |
|
Agreed, it would be nice to fix this, but I guess we'd end up needing to patch LLVM's libunwind. |
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
…uliaLang#43613) We just don't get more than a couple frames back from libunwind on stack overflow when running on aarch64-darwin, so restrict the test to x64_64 also on macOS. This test also fails using the official 1.7.0 release binary.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…uliaLang#43613) We just don't get more than a couple frames back from libunwind on stack overflow when running on aarch64-darwin, so restrict the test to x64_64 also on macOS. This test also fails using the official 1.7.0 release binary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We just don't get more than a couple frames back from libunwind
on stack overflow when running on aarch64-darwin, so restrict the
test to x64_64 also on macOS.
This test also fails using the official 1.7.0 release binary.