[REPLCompletions] follow up #43865, keep input tuple type in MethodCompletion
#43946
Conversation
stdlib/REPL/src/REPLCompletions.jl
Outdated
| @@ -515,20 +517,20 @@ function get_type(T, found::Bool, default_any::Bool) | |||
| end | |||
|
|
|||
| # Method completion on function call expression that look like :(max(1)) | |||
| MAX_METHOD_COMPLETIONS = 40 | |||
| const MAX_METHOD_COMPLETIONS = Ref(40) | |||
There was a problem hiding this comment.
why? this just adds more overhead
There was a problem hiding this comment.
If we configure this value, it feels "better" if we can do REPL.REPLCompletions.MAX_METHOD_COMPLETIONS[] = 100 instead of @eval REPL.REPLCompletions MAX_METHOD_COMPLETIONS = 100.
There was a problem hiding this comment.
It is not really configurable. It is a function argument though, if desired.
There was a problem hiding this comment.
Then we basically need to copy and paste the definitions of complete_methods etc. If it's not really supposed to be configured, we should probably make it const.
There was a problem hiding this comment.
Just because we make it less convenient to change, does not mean we have to make it const
There was a problem hiding this comment.
If people eventually do need to change it regularly, this will let them try out the idea, then add a contextual parameters object to this code to encapsulate any configurations of interest
There was a problem hiding this comment.
gotcha, let's just remove this change.
…ompletion` `MethodCompletion.tt` is being used by an external consumer like Juno or VSCode's runtime completion features to get additional information like return type, etc. Co-Authored-By: Jameson Nash <[email protected]>
aviatesk
force-pushed
the
avi/follow43865
branch
from
0d436b1 to
4cd2c98
Compare
… `MethodCompletion` (JuliaLang#43946) `MethodCompletion.tt` is being used by an external consumer like Juno or VSCode's runtime completion features to get additional information like return type, etc.
… `MethodCompletion` (JuliaLang#43946) `MethodCompletion.tt` is being used by an external consumer like Juno or VSCode's runtime completion features to get additional information like return type, etc.
MethodCompletion.ttis being used by an external consumer like Juno orVSCode's runtime completion features to get additional information like
return type, etc.