optimizer: keep statements that may throw from being optimized by SROA #48068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
reviewed
Jan 1, 2023
|
@nanosoldier |
|
Your job failed. |
SROA should verify a statement won't throw, otherwise it can't be eliminated safely. Note that this commit skips the nothrow-ness verification on `getfield` statement. This is acceptable because currently we are unable to prove it in the presence of potentially undefined fields. This is okay because our SROA pass will eliminate such a `getfield` statement only if it determines that the forwarded value safely defines the potentially undefined field.
|
@nanosoldier |
Keno
approved these changes
Jan 4, 2023
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
|
The test failures on Windows seem not to relate to this change. Going to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SROA should verify a statement won't throw, otherwise it can't be eliminated safely.
Note that this commit skips the nothrow-ness verification on
getfieldstatement. This is acceptable because currently we are unable to prove it in the presence of potentially undefined fields. This is okay because our SROA pass will eliminate such agetfieldstatement only if it determines that the forwarded value safely defines the potentially undefined field.fixes #48067.