Remove @inbounds in tuple iteration
#48260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
added a commit
to JuliaDiff/Diffractor.jl
that referenced
this pull request
Jan 12, 2023
Similar to JuliaLang/julia#48260, this `@inbounds` hurts effects tainting.
Keno
added a commit
to JuliaDiff/Diffractor.jl
that referenced
this pull request
Jan 12, 2023
Similar to JuliaLang/julia#48260, this `@inbounds` hurts effects tainting.
Keno
added a commit
to JuliaDiff/Diffractor.jl
that referenced
this pull request
Jan 13, 2023
Similar to JuliaLang/julia#48260, this `@inbounds` hurts effects tainting.
aviatesk
approved these changes
Jan 13, 2023
|
Sigh, guess the final version of my PR wasn't actually enough to retain consitency here. I'll push an update. |
|
Guess the Lines 2198 to 2205 in 2ca0981 |
|
Yes. I have most of a fix, but something is breaking, so I'll have to resume in the morning. |
LLVM can prove this inbounds and the annotation weakens the inferable effects for tuple iteration, which has a surprisingly large inference performance and precision impact. Unfortunately, my previous changes to :inbounds tainting weren't quite strong enough yet, because `getfield` was still tainting consistency on unknown boundscheck arguments. To fix that, we pass through the fargs into the fetfield effects to check if we're getting a literal `:boundscheck`, in which case the `:noinbounds` consistency-tainting logic I added in #48246 is sufficient to not require additional consistency tainting. Also add a test for both effects and codegen to make sure this doens't regress.
|
CI isn't running on this PR - not sure why. Let me just recreate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM can prove this inbounds and the annotation weakens the inferable effects for tuple iteration, which has a surprisingly large inference performance and precision impact. Add a test for both effects and codegen to make sure this doens't regress.