Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing return case in isidentitytype #48321

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Add missing return case in isidentitytype #48321

merged 1 commit into from
Jan 18, 2023

Conversation

Keno
Copy link
Member

@Keno Keno commented Jan 17, 2023

Fixes #48313.

@Keno Keno added the backport 1.9 Change should be backported to release-1.9 label Jan 17, 2023
@KristofferC
Copy link
Member

This doesn't look applicable to 1.9 so maybe it is fine there? This function was introduced in #48234

@Keno Keno removed the backport 1.9 Change should be backported to release-1.9 label Jan 17, 2023
@giordano
Copy link
Contributor

Needs tests?

vtjnash
vtjnash approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/isidentitytype/isidentityfree, though it does note this function deviates from the usual naming convention in this file to add type to the end of the names

@Keno Keno merged commit e1fc482 into master Jan 18, 2023
@Keno Keno deleted the kf/48313 branch January 18, 2023 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

@aviatesk aviatesk aviatesk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Internal compiler error: type error in adjust_effects
5 participants
@Keno @KristofferC @giordano @vtjnash @aviatesk