Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ITTAPI source for offline #49022

Merged
merged 2 commits into from
Mar 27, 2023
Merged

Add ITTAPI source for offline #49022

merged 2 commits into from
Mar 27, 2023

Conversation

vchuravy
Copy link
Member

Fixes #47989

@Nickgao or @nalimilan ould you give this a go?

@vchuravy

This comment was marked as resolved.

Sign in to view
@vchuravy vchuravy added backport 1.8 Change should be backported to release-1.8 backport 1.9 Change should be backported to release-1.9 labels Mar 17, 2023
staticfloat
staticfloat reviewed Mar 17, 2023
View reviewed changes
deps/ittapi.mk Outdated Show resolved Hide resolved
@KristofferC KristofferC mentioned this pull request Mar 24, 2023
Merged
52 tasks
@nalimilan
Copy link
Member

Thanks! I confirm it fixes the problem when building the Fedora RPM.

Should probably add a mention to THIRDPARTY.md, julia.spdx.json and doc/src/devdocs/build/build.md?

@vchuravy vchuravy requested a review from nalimilan March 26, 2023 21:19
@vchuravy vchuravy added the building Build system, or building Julia or its dependencies label Mar 26, 2023
nalimilan
nalimilan approved these changes Mar 27, 2023
View reviewed changes
doc/src/devdocs/build/build.md Outdated Show resolved Hide resolved
@vchuravy @nalimilan
Update doc/src/devdocs/build/build.md
75b7c37 
Co-authored-by: Milan Bouchet-Valat <[email protected]>
@vchuravy vchuravy merged commit 6b934f9 into master Mar 27, 2023
@vchuravy vchuravy deleted the vc/ittapi branch March 27, 2023 14:28
KristofferC pushed a commit that referenced this pull request Mar 30, 2023
@vchuravy @KristofferC
Add ITTAPI source for offline (#49022)
c4ab115 
* Add ITTAPI sources for offline build

Co-authored-by: Milan Bouchet-Valat <[email protected]>
(cherry picked from commit 6b934f9)
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Mar 31, 2023
nalimilan
nalimilan reviewed Apr 11, 2023
View reviewed changes
deps/llvm.mk
@@ -286,6 +286,11 @@ configure-llvm: $(LLVM_BUILDDIR_withtype)/build-configured
compile-llvm: $(LLVM_BUILDDIR_withtype)/build-compiled
fastcheck-llvm: #none
check-llvm: $(LLVM_BUILDDIR_withtype)/build-checked

ifeq ($(USE_INTEL_JITEVENTS),1)
extract-llvm: $(SRCCACHE)/$(ITTAPI_SRC_DIR)/source-extracted
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I think this should be:

$(SRCCACHE)/$(LLVM_SRC_DIR)/source-extracted: $(SRCCACHE)/$(ITTAPI_SRC_DIR)/source-extracted

@nalimilan
Copy link
Member

Sorry, I think I had incorrectly checked this with USE_BINARYBUILDER_LLVM=1. Now with USE_BINARYBUILDER_LLVM=0 I get the original error from #47989 again (see logs).

I think one reason is that building LLVM does not extract the ITTAPI tarball, since the compile-llvm target depends on build-configured, which in turn depends on source-extracted, but not on extract-llvm. See my suggestion above to fix this.

However, even with that change, configure-llvm tries to clone the git repo, despite -DITTAPI_SOURCE_DIR=/home/milan/Dev/rpmbuild/BUILD/julia-1.9.0-rc2/deps/srccache/ittapi-0014aec56fea2f30c1374f40861e1bccdd53d0cb pointing to the correct location of the sources. Any ideas?

Xnartharax pushed a commit to Xnartharax/julia that referenced this pull request Apr 19, 2023
@vchuravy @nalimilan @Xnartharax
Add ITTAPI source for offline (JuliaLang#49022)
6dcc9ba 
* Add ITTAPI sources for offline build

Co-authored-by: Milan Bouchet-Valat <[email protected]>
@vchuravy vchuravy mentioned this pull request Jun 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inkydragon inkydragon inkydragon left review comments

@nalimilan nalimilan nalimilan approved these changes

@staticfloat staticfloat staticfloat left review comments

@topolarity topolarity Awaiting requested review from topolarity

Assignees
No one assigned
Labels
backport 1.8 Change should be backported to release-1.8 building Build system, or building Julia or its dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Offline build from julia-1.8.4-full.tar.gz failes dues to missing source for ittapi
5 participants
@vchuravy @nalimilan @staticfloat @inkydragon @KristofferC