-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add regressions to changelog (NEWS.md) #49883
Conversation
The tone of these bullet points feels off to me and the descriptions are also much more general than the actual concrete issue. I think it is best to just link to the issues without trying to summarize them because any such attempt will lose too much details. Something like:
|
For a user considering updating his perfectly working code to a new julia version, regressions are as, or even more important than new features. Sorry if the tone sounds off, that was my crude attempt at making issue titles sound reasonable as bullet points. As a non-native speaker, I would appreciate any improvements here. |
NEWS.md
Outdated
----------- | ||
|
||
* Precompilation takes significantly longer, 2x-3x compilations slowdowns are common | ||
* Some type-unstable code runs orders of magnitude slower ([#48612]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quoting myself from slack:
Remember to add the improvement back in the release notes of 1.10 too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how to make PR with changes to two branches at once
bump... |
The set of regressions in a release is a moving target since new ones can be found at any point. Therefore, I don't think it makes sense to store this information in a place that can not be mutated. How about adding a GitHub issue label (e.g. "regression 1.9") and linking to the list of such issues from this place? |
Thanks @KristofferC, that's a nice suggestion! Implemented by adding a link to news.md. |
Co-authored-by: Kristoffer Carlsson <[email protected]>
Gentle bump... |
Following recent slack discussion, https://julialang.slack.com/archives/C67910KEH/p1683570942857959.
Brief summary of that:
References issues: #48612 (mine) JuliaLang/LinearAlgebra.jl#998 (@pablosanjose) #48217 (@Moelf). Feel free to append more, or give more details!