-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiment with WorkStealing #50221
Draft
vchuravy
wants to merge
8
commits into
master
Choose a base branch
from
vc/ws
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Experiment with WorkStealing #50221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
added
speculative
Whether the change will be implemented is speculative
performance
Must go faster
multithreading
Base.Threads and related functionality
labels
Jun 20, 2023
3 tasks
For my own record (with 4 threads). WSQueue improved I am not sure how to make WSQueue fully correct so I will probably investigate a lock-free double ended queue. |
So this triggers an assertion when building with more than one thread set because if (jl_base_module == NULL) {
// nthreads > 1 requires code in Base
jl_atomic_store_relaxed(&jl_n_threads, 1);
jl_n_markthreads = 0;
jl_n_sweepthreads = 0;
jl_n_gcthreads = 0;
} doesn't set the threadpool stuff, though I guess maybe it should @vtjnash? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
multithreading
Base.Threads and related functionality
performance
Must go faster
speculative
Whether the change will be implemented is speculative
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically a continuation from #43366.
It shows similar promise for
pfib
, but I was actually motivatedby the benchmark in #50202 (comment)
where we did a lot of work trying to figure out if there are no more tasks to run.
One issue I am aware off is that the underlying data-structure is not GC friendly.
Fundamentally we will only copy over data in the buffer, we are gurantueed to only
read valid data, but on the unused pieces of the buffer we have task-corpses laying
around.
A second issue is that the current implementation only allows for one thread to
push!
andpopfirst!
,while all other threads are only allowed to
steal!
.It looks like Go uses a double-ended queue.