-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize gvars with their pointer values in create_native #50838
Conversation
I thought we had exported an accessor to get the mapping from index to global back, which avoids the need to embed runtime state like this. But the PR looks good to merge anyways if it is fixing issues for now. |
Given that we have external consumers of |
I don't think that is exported. |
Oh, really? How do you manage to do anything without the expected struct accessors for the state: Lines 86 to 116 in 2d24155
|
We only use Can we use |
GPUCompiler won't have access to the runtime pointers for global variables emitted from
jl_create_native
, so we need to provide them here.