-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
codegen: implement isdefined_tfunc check more similarly to inference #52069
Conversation
I guess this can supercede #52068? |
Oops, turns out that this optimization is unsound for inference / codegen to attempt since some packages (e.g. NetworkOptions) relies on the non-existence of this optimization--we therefore may need to delete this optimization from inference. |
How can they tell whether this optimization was performed? |
They segfault if the code gets reinferred |
Part of the cleanup here is perhaps worthwhile (merging code paths into a common helper function), but the main change has been removed from inference for correctness reasons in #53750 |
1641188
to
daf57cc
Compare
daf57cc
to
91a74dc
Compare
CI is all green here. @vtjnash Is this good to merge now, or are you still waiting on a review from Valentin and/or Gabriel? |
It is fine now to merge |
No description provided.