inlining: Use tfunc for inserted isa/and calls
#54209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For extended lattice elements, the type of the resulting PiNode can end up imprecise when `tmeet(argextype(argex), mft) ⊑ mft`
The motivation for this is the same as JuliaLang#54105, where the return types being filled in by inference can in general be imprecise when running the compiler with an extended lattice. This PR is very incomplete - There are at least 6+ more places in `inlining.jl` where we hard-code return types that will need similar treatment.
topolarity
force-pushed
the
ct/isa-tfunc
branch
from
32411a0 to
0f59633
Compare
aviatesk
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
@nanosoldier runbenchmarks("inference", vs=":master")
Other optimization passes also have hardcoded native types, we might need to tweak them too in the future.
Keno
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
I am slightly unhappy about the extra overhead, but I'd rather have this correct first and look into putting fastpaths into the tfuncs later if necessary (if we new this was const in the base lattice, the compiler should be able to determine that as well, but of course, it may not be seeing all the constraints).
|
I think these are fairly trivial functions, especially as normal tfunc usage requires that constant always be handled before calling these |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for this is the same as #54105, where the return types being filled in by inference can in general be imprecise when running the compiler with an extended lattice.
Note that this PR is very incomplete.
There are at least 6+ more places in
inlining.jlwhere we hard-code return types that will need similar treatment, but for now this resolves some downstream bugs from these imprecise types.