Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#54739-related fixes for loading stdlibs #54891

Merged
merged 2 commits into from
Jun 24, 2024
Merged

#54739-related fixes for loading stdlibs #54891

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cf14aa
fix issue with loading stdlibs stalecheck inconsistency
vtjnash Jun 22, 2024
b260cab
block loading extensions when the package is not yet requested
vtjnash Jun 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions base/loading.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1935,9 +1935,10 @@ end
dep = staledeps[i]
dep isa Module && continue
modpath, modkey, modbuild_id, modcachepath, modstaledeps, modocachepath = dep::Tuple{String, PkgId, UInt128, String, Vector{Any}, Union{Nothing, String}}
dep = get(loaded_precompiles, modkey => modbuild_id, nothing)
if dep === nothing
if stalecheck
dep = maybe_root_module(modkey)
else
dep = get(loaded_precompiles, modkey => modbuild_id, nothing)
end
while true
if dep isa Module
Expand Down Expand Up @@ -1978,7 +1979,7 @@ end
finally
for modkey in newdeps
insert_extension_triggers(modkey)
run_package_callbacks(modkey)
stalecheck && run_package_callbacks(modkey)
end
empty!(newdeps)
end
Expand Down