-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix edge case in rational number conversion float(a//b)
#56772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes rational docs
nsajko
added
docs
This change adds or pertains to documentation
rationals
The Rational type and values thereof
maths
Mathematical functions
labels
Dec 7, 2024
fingolfin
reviewed
Dec 8, 2024
Co-authored-by: Max Horn <[email protected]>
KristofferC
reviewed
Dec 10, 2024
added mising line
inkydragon
approved these changes
Dec 18, 2024
inkydragon
changed the title
Fix complex - rational docs
docs: fix edge case in rational number conversion Dec 18, 2024
float(a//b)
giordano
added
backport 1.10
Change should be backported to the 1.10 release
backport 1.11
Change should be backported to release-1.11
and removed
merge me
PR is reviewed. Merge when all tests are passing
labels
Dec 18, 2024
KristofferC
pushed a commit
that referenced
this pull request
Jan 2, 2025
Fixes #56726 added the changes that were suggested. fixing the mistake. --------- Co-authored-by: Max Horn <[email protected]> Co-authored-by: Chengyu Han <[email protected]> (cherry picked from commit fc9e7c4)
36 tasks
KristofferC
pushed a commit
that referenced
this pull request
Jan 2, 2025
Fixes #56726 added the changes that were suggested. fixing the mistake. --------- Co-authored-by: Max Horn <[email protected]> Co-authored-by: Chengyu Han <[email protected]> (cherry picked from commit fc9e7c4)
stevengj
pushed a commit
that referenced
this pull request
Jan 2, 2025
Fixes #56726 added the changes that were suggested. fixing the mistake. --------- Co-authored-by: Max Horn <[email protected]> Co-authored-by: Chengyu Han <[email protected]>
KristofferC
pushed a commit
that referenced
this pull request
Jan 13, 2025
Fixes #56726 added the changes that were suggested. fixing the mistake. --------- Co-authored-by: Max Horn <[email protected]> Co-authored-by: Chengyu Han <[email protected]> (cherry picked from commit fc9e7c4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 1.10
Change should be backported to the 1.10 release
backport 1.11
Change should be backported to release-1.11
docs
This change adds or pertains to documentation
maths
Mathematical functions
rationals
The Rational type and values thereof
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56726 added the changes that were suggested. fixing the mistake.