Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix edge case in rational number conversion float(a//b) #56772

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

Priynsh
Copy link
Contributor

@Priynsh Priynsh commented Dec 7, 2024

Fixes #56726 added the changes that were suggested. fixing the mistake.

@nsajko nsajko added docs This change adds or pertains to documentation rationals The Rational type and values thereof maths Mathematical functions labels Dec 7, 2024
@inkydragon inkydragon added the merge me PR is reviewed. Merge when all tests are passing label Dec 18, 2024
@inkydragon inkydragon changed the title Fix complex - rational docs docs: fix edge case in rational number conversion float(a//b) Dec 18, 2024
@giordano giordano merged commit fc9e7c4 into JuliaLang:master Dec 18, 2024
9 checks passed
@giordano giordano added backport 1.10 Change should be backported to the 1.10 release backport 1.11 Change should be backported to release-1.11 and removed merge me PR is reviewed. Merge when all tests are passing labels Dec 18, 2024
KristofferC pushed a commit that referenced this pull request Jan 2, 2025
Fixes #56726 added the changes that were suggested. fixing the mistake.

---------

Co-authored-by: Max Horn <[email protected]>
Co-authored-by: Chengyu Han <[email protected]>
(cherry picked from commit fc9e7c4)
@KristofferC KristofferC mentioned this pull request Jan 2, 2025
36 tasks
KristofferC pushed a commit that referenced this pull request Jan 2, 2025
Fixes #56726 added the changes that were suggested. fixing the mistake.

---------

Co-authored-by: Max Horn <[email protected]>
Co-authored-by: Chengyu Han <[email protected]>
(cherry picked from commit fc9e7c4)
@KristofferC KristofferC mentioned this pull request Jan 2, 2025
51 tasks
stevengj pushed a commit that referenced this pull request Jan 2, 2025
Fixes #56726 added the changes that were suggested. fixing the mistake.

---------

Co-authored-by: Max Horn <[email protected]>
Co-authored-by: Chengyu Han <[email protected]>
KristofferC pushed a commit that referenced this pull request Jan 13, 2025
Fixes #56726 added the changes that were suggested. fixing the mistake.

---------

Co-authored-by: Max Horn <[email protected]>
Co-authored-by: Chengyu Han <[email protected]>
(cherry picked from commit fc9e7c4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.10 Change should be backported to the 1.10 release backport 1.11 Change should be backported to release-1.11 docs This change adds or pertains to documentation maths Mathematical functions rationals The Rational type and values thereof
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation about "Conversion from rational to floating-point"
6 participants