precompileplkgs: release parallel limiter when waiting for another process #56844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
added
the
backport 1.11
IanButterworth
force-pushed
the
ib/precompile_parallel_narrow
branch
from
9cd7234 to
b7c4962
Compare
IanButterworth
changed the title
|
This means that if one process has 3 packages it wants to precompile and it now wants to precompile one which is already being precompiled by another process, it goes and precompiles one of the others instead? |
|
Indeed. And the one it's waiting on will remain in the list with the pidlock message. |
|
Here both of these have 7 ( |
KristofferC
approved these changes
Dec 17, 2024
stevengj
pushed a commit
that referenced
this pull request
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents a process waiting for a pidlock if another process is working on that thing, if this process can do other things.
Should help resource constrained workers sharing a depot, however if those workers aren't properly CPU constrained then this could exacerbate oversubscribing the system.
Here both of these have 7 (
CPU_THREADS+1) tasks actually precompiling