Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JuliaLang/JuliaSyntax.jl#525 to NEWS.md and flisp parser #57143

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pthariensflame
Copy link
Contributor

@pthariensflame pthariensflame commented Jan 23, 2025

Now that JuliaLang/JuliaSyntax.jl#525 has been merged, also add it to the flisp parser, and document it!

@Keno
Copy link
Member

Keno commented Jan 23, 2025

Also needs to be added in the flisp parser and needs to wait for the JuliaSyntax version bump.

@nsajko nsajko added the docs This change adds or pertains to documentation label Jan 23, 2025
@pthariensflame pthariensflame changed the title Add JuliaLang/JuliaSyntax.jl#525 to NEWS.md Add JuliaLang/JuliaSyntax.jl#525 to NEWS.md and flisp parser Jan 24, 2025
@pthariensflame
Copy link
Contributor Author

@Keno @nsajko This PR now also adds support for U+1F8B2 🢲 to the flisp parser and with it the Base id char functions.

Correspondingly adds it to the Base id char functions too
@nsajko nsajko added parser Language parsing and surface syntax feature Indicates new feature / enhancement requests needs tests Unit tests are required for this change and removed docs This change adds or pertains to documentation labels Jan 25, 2025
@nsajko
Copy link
Contributor

nsajko commented Jan 25, 2025

I'm guessing this PR will also need tests, so I added the label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Indicates new feature / enhancement requests needs tests Unit tests are required for this change parser Language parsing and surface syntax
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants