Make the REPL re-entrant and easier to debug #6413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @loladiro |
|
LGTM in general, but see Travis failure. |
|
Oops. I've made the |
| @@ -39,6 +39,9 @@ type Prompt <: TextInterface | |||
| hist | |||
| end | |||
|
|
|||
| string(x::Prompt) = string("Prompt(\"", x.prompt, "\",...)") | |||
| show(io::IO, x::Prompt) = print(io, string(x)) | |||
There was a problem hiding this comment.
I think it suffices to define print and you get both of these automatically.
There was a problem hiding this comment.
Ah, you're right, the string method definition is superfluous. The chain goes string -> print -> show.
Prevent a recursive show call with Prompt objects
Previously, the keymap functions were assigned a name with the eval macro (in global scope). This changes the keymap macro to instead return an anonymous function so that additional instances of the REPL don't clobber the keymap functions of previous ones.
|
I've removed the superfluous |
Keno
added a commit
that referenced
this pull request
Apr 4, 2014
Make the REPL re-entrant and easier to debug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two patches here simplify working with the REPL itself. The first allows for printing of REPL objects in the REPL. The second makes it re-entrant.
Previously, the keymap functions were assigned a name with the eval macro (that is - in global scope). This changes the keymap macro to instead return an anonymous function so that additional instances of the REPL don't clobber the previous keymap functions.
So, you can now start a second REPL inside the first. I've found this particularly useful for testing keybindings, but I could see it being useful in other cases, too.
Base.REPL.run_repl(Base.REPL.LineEditREPL(Base.Terminals.TTYTerminal(get(ENV,"TERM",""),STDIN,STDOUT,STDERR)))cc: @nolta @loladiro