RFC: use unicode character categories to classify identifier characters #6805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cat == UTF8PROC_CATEGORY_LO || cat == UTF8PROC_CATEGORY_NL || | ||
| // allow currency symbols | ||
| cat == UTF8PROC_CATEGORY_SC || | ||
| // allow all latin-1 characters except math symbols and quotes |
There was a problem hiding this comment.
Punctuation characters cannot occur here?
…g So) add category No for identifier continue chars
fix strings test to recognize changed error for invalid identifiers
JeffBezanson
added a commit
that referenced
this pull request
May 13, 2014
RFC: use unicode character categories to classify identifier characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6797, fixes #5936