-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #5154 (nested for loop syntax & break behavior) #7430
Conversation
Wow, thanks, I forgot about this one. I think it would be good to put this in 0.3. |
+1 |
(if (null? r) | ||
body | ||
`(for ,(car r) ,(nest (cdr r))))))) | ||
`(for ,(car ranges) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should parse as a single for
expression, with a (tuple ...)
of the ranges. The parsed form should visually match the source code. All the inner-
forms will then be confined to lowering, where they will not bother people.
Ok I think this is now ready to go. |
fix #5154 (nested for loop syntax & break behavior)
According to bisect, merging this (dd85daa) caused the following test failure on Win64:
Looks a little like #5153? |
And it went away again. The hell? |
That is a very slippery error, probably GC-related, that is very sensitive to the exact allocation workload. |
Output of:
before:
and after: