Extend llvmcall with support for entering declarations. #8673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to
llvmcall
for inserting required declarations in the module. This is useful when you want tollvmcall
intrinsics, because LLVM refuses to parse IR with undeclared identifiers (for example, see this thread).The idea behind this solution is to allow passing a tuple
(decls, ir)
as first argument tollvmcall
, where currently only an IR string or a pointer to a LLVM function is allowed. Thedecls
IR is then pasted before the functionllvmcall
generates. In order to avoid duplicate declarations, which LLVM does not like, a global set keeps track of the declarations added to the current module.Example usage:
As mentioned in issue #8308 I also tried other approaches, such as automatically parsing identifiers in the IR, but that turned out pretty fragile.