Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have failed to convince @StefanKarpinski and @JeffBezanson in #9170 and that pr is therefore superseded by this which adds some error messages for
(c)transpose
ofAbstractMatrix
s instead of removing the transpose methods defined forAny
. For the record I'll note that I don't think it is the right solution as new matrix like types that are not subtypes ofAbstractMatrix
will silently return wrong results for(c)transpose
.For the QR example that revealed this issue, the result is now
As part of the tranpose fix, I have added
(c)transpose
forGivens
andRotation
types and changed theAbstractRotation
to be an abstract type instead of a union. I have also removed ther
property from theGivens
type. Instead, it is returned from the givens method. Ther
property wouldn't make sense for the transposed rotation and I think it is a better design in general.cc: @jiahao, @ivanslapnicar