Fix mod1 #9643
Merged
Fix mod1 #9643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -131,7 +131,7 @@ const % = rem | |||
| const ÷ = div | |||
|
|
|||
| # mod returns in [0,y) whereas mod1 returns in (0,y] | |||
| mod1{T<:Real}(x::T, y::T) = y-mod(y-x,y) | |||
| mod1{T<:Real}(x::T, y::T) = (m=mod(x,y); m==0 ? y : m) | |||
|
Bump! (needs a rebase because git is don't know what order to append new tests at the bottom of |
|
And not really the slow old implementation, but equally fast (due to the use of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore old implementation of mod1 that was overwritten in 3842422
Adds test of mod1 behavior from #5570
Note: #5570 is not fixed for fld1, rem1. The documentation bug of #8108 is not fixed.
cc: @GunnarFarneback @StefanKarpinski @mschauer