-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing windows tests with 2023.2 #130
Comments
Its tripping up because MKL is leaving the Probably, the MKL tests should be run with the environment variable |
The test suite needs to ignore any changes to the environment because loading MKL's shared library on some platforms (such as Windows) can create environment variables for OpenMP (e.g. __KMP_REGISTERED_LIB_<PID>) that live the entire Julia session and make the environment appear modified. Fixes JuliaLinearAlgebra#130
PR #47148 added the ability to ignore changes to the environment in a testsuite (using the `JULIA_TEST_CHECK_MUTATED_ENV` environment variable), but didn't hide the printing of the error message. This hides the actual error message so that the terminal isn't cluttered with them when they should be ignored. This is needed because in the MKL.jl testsuite, the error is hit for basically every linear algebra test (JuliaLinearAlgebra/MKL.jl#130), and so even when we have already disabled the error, printing the error message causes lots of noise on the terminal that can possibly hide other problems. Co-authored-by: Dilum Aluthge <[email protected]>
Almost all the tests fail with this. Not sure what is happening here and if it is a Julia issue or something else in MKL.
Seen in #123 and logs in https://github.com/JuliaLinearAlgebra/MKL.jl/actions/runs/5786517472/job/15681397696
The text was updated successfully, but these errors were encountered: