Merge pull request #12 from tanmaykm/tan/misc

fix exception stack traces

Project.toml

@@ -3,7 +3,7 @@ uuid = "c41e01d8-14e5-11ea-185b-e7eabed7be4b"
 keywords = ["log", "rotate", "roller", "logrotate"]
 license = "MIT"
 authors = ["Tanmay Mohapatra <[email protected]>"]
-version = "0.4.1"
+version = "0.4.2"
 
 [compat]
 julia = "1.2,1.3,1.4,1.5"

src/LogRoller.jl

@@ -258,7 +258,9 @@ function handle_message(logger::RollingLogger, level, message, _module, group, i
             end
             for (key, val) in kwargs
                 kwarg_timestamp && (key === logger.timestamp_identifier) && continue
-                println(iob, "│   ", key, " = ", val)
+                print(iob, "│   ", key, " = ")
+                Logging.showvalue(iob, val)
+                println(iob)
             end
             println(iob, "└ @ ", something(_module, "nothing"), " ", something(filepath, "nothing"), ":", something(line, "nothing"))
         catch ex

test/runtests.jl

@@ -361,7 +361,7 @@ function test_json_format()
 
             entry = JSON.parse(readio)
             @test entry["metadata"]["level"] == "Info"
-            @test endswith(entry["message"], "Array{Bool,1}") # either "Array{Bool,1}" or "Vector{Bool} = Array{Bool,1}"
+            @test endswith(entry["message"], "Array{Bool,1}") || startswith(entry["message"], "Vector{Bool}") # either "Array{Bool,1}" or "Vector{Bool} = Array{Bool,1} or Vector{Bool} (alias for...)"
 
             entry = JSON.parse(readio)
             @test entry["metadata"]["level"] == "Error"
@@ -435,6 +435,43 @@ function test_size_limits()
     end
 end
 
+function test_exception_printing()
+    mktempdir() do logdir
+        filename = "test.log"
+        filepath = joinpath(logdir, filename)
+
+        logger = RollingLogger(filepath, 2000, 3; format=:json)
+        with_logger(logger) do
+            try
+                error("test exception")
+            catch ex
+                @error("caught exception", exception=(ex,catch_backtrace()))
+            end
+        end
+        close(logger)
+        open(filepath) do readio
+            entry = JSON.parse(readio)
+            lines = readlines(IOBuffer(entry["keywords"]["exception"]))
+            @test length(lines) > 10
+        end
+    end
+    mktempdir() do logdir
+        filename = "test.log"
+        filepath = joinpath(logdir, filename)
+
+        logger = RollingLogger(filepath, 2000, 3; format=:console)
+        with_logger(logger) do
+            try
+                error("test exception")
+            catch ex
+                @error("caught exception", exception=(ex,catch_backtrace()))
+            end
+        end
+        close(logger)
+        @test length(readlines(filepath)) > 10
+    end
+end
+
 @testset "file writer" begin
     test_filewriter()
 end
@@ -450,4 +487,6 @@ end
     test_postrotate()
     test_json_format()
     test_size_limits()
+    test_exception_printing()
 end
+